Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ddc] Cleanup all support for unsound null safety #55692

Open
nshahan opened this issue May 10, 2024 · 0 comments
Open

[ddc] Cleanup all support for unsound null safety #55692

nshahan opened this issue May 10, 2024 · 0 comments
Assignees
@nshahan
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. web-dev-compiler

Comments

@nshahan
Copy link
Contributor

nshahan commented May 10, 2024

This is a catch all issue for anything used to support unsound null safety in DDC we can think of that should eventually be refactored or deleted.

  • SDK build targets for compiling unsound .dill and .js files.
  • test_matrix.json configurations.
  • pkg/test_runner support for DDC with unsound null safety.
  • @notNull and @nullCheck annotations used in the runtime library and patch files.
  • The nullable_inference librarypkg/dev_compiler/lib/src/kernel/nullable_inference.dart.
  • Compile time soundNullSafety option and all code that branches on it.
  • Runtime mode flags and all code that branches on them:
  • pkg/dev_compiler/test suites that run with unsound null safety.
  • DDB script support for --no-sound-null-safety.

Edit this list to add more as we discover them. Link cleanup changes to this issue.
@nshahan nshahan added web-dev-compiler area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. labels May 10, 2024
@nshahan nshahan self-assigned this May 10, 2024
copybara-service bot pushed a commit that referenced this issue May 10, 2024
@nshahan
[ddc] Update some sourcemap locations
1a0dd10 
* Add special handling for String concatenations so the first string
  gets mapped correctly and work better in sound null safety.
* Update variable assignments to more consistently point to helpful
  locations, specifically when lowered from a prefix increment like
  `++x`.
* Run the sourcemap and stacktrace test suites with sound null safety.

Previously these suites were running with unsound null safety so more
operations were wrapped in function calls to check for null. Those calls
allowed for mode step or break points that hid some of the issues
addressed in this change.

Issue: #55692

Change-Id: Ibd887c8da64e72ab84c0698dd49b845abfaedbb8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366025
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
copybara-service bot pushed a commit that referenced this issue May 10, 2024
@nshahan
[ddc] Run nullable inference test in sound null safety
7d82eb6 
Use a list of strings in the expectations to make it easier to
format correctly when there are more non-nullable expressions.

Follow up changes will remove more tests configurations, and null
safety mode plumbing for the DDC infra.

Issue: #55692

Change-Id: Ia1d9084368c2f8dd6fb7b184026328e022c51718
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/365546
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
copybara-service bot pushed a commit that referenced this issue May 13, 2024
@nshahan
[ddc] Delete more unsound null safety tests
03a0467 
These were tests of the expression compiler and worker when
the source code under test was running with unsound null
safety.

Issue: #55692
Change-Id: Ia34a7203fc24295dd1dde246a56ca29add4009d3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366180
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nshahan nshahan

Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. web-dev-compiler
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nshahan