New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE] Lots of missing Optional
s in the type hinting
#564
Comments
Optional
s in the type hinting Optional
s in the type hinting of WorkspaceClient
@judahrand are you aware of mypy's I appreciate that not everyone uses that style (and I would personally discourage library authors from doing so as being explicit is usually clearer), however my understanding is that the spelling used in this project shouldn't impact how your project is type-checked. If it does, that may be a bug (e.g: python/mypy#9208) in your type checker and/or you may need to configure handling of implicit optionals if it's intentional that this project uses that style. |
To be honest, this project doesn't make use of mypy typechecking quite yet. We've been meaning to add support for it, and I think we'd be open to discussion about whether enabling |
I think that using explicit |
This seems reasonable to me, especially as this seems to be the direction that mypy and the ecosystem are moving towards. |
This might not be the right place to raise this but it would be nice if this could be changed/updated in |
Optional
s in the type hinting of WorkspaceClient
Optional
s in the type hinting
Description
In lots of places the SDK's type hints look like:
This typing is incorrect and should be:
The text was updated successfully, but these errors were encountered: