Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Traversing for .databricks.env from notebook init scripts has unintended sideeffects #962

Open
kartikgupta-db opened this issue Dec 4, 2023 · 0 comments
Open

[BUG] Traversing for .databricks.env from notebook init scripts has unintended sideeffects #962

kartikgupta-db opened this issue Dec 4, 2023 · 0 comments
Assignees
@kartikgupta-db
Labels
bug Something isn't working

Comments

@kartikgupta-db
Copy link
Contributor

Describe the bug
We are traversing up to find a .databricks/.databricks.env file. This can lead to unintended cases where a user opens the root folder with the extension, leading to creation of the .databricks folder. Any subfolders will always load this .databrick.env now and it will not be possible to NOT use databricks.

This was done since loading env variables from a python.envFile was not very reliable for vscode notebooks. But this was fixed in a recent fix microsoft/vscode-jupyter#14105. We might be able to safely rely on these env vars now.
@kartikgupta-db kartikgupta-db added the bug Something isn't working label Dec 4, 2023
@kartikgupta-db kartikgupta-db self-assigned this Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kartikgupta-db kartikgupta-db

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kartikgupta-db