Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature streaming enhancments #127

Open
wants to merge 40 commits into
base: master
Choose a base branch
from
Open

Feature streaming enhancments #127

wants to merge 40 commits into from

Conversation

ronanstokes-db
Copy link
Contributor

@ronanstokes-db ronanstokes-db commented Oct 20, 2022 •
edited

Proposed changes

Added support for rate-micro-batch source
Added ageLimit option for rate source
More extensive testing for streaming scenarios

Note: still work in progress - PR opened to validate unit tests on GitHub build runner

Types of changes

What types of changes does your code introduce to dbldatagen?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Change to tutorials, tests or examples
  • Non code change (readme, images or other non-code assets)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules
  • Submission does not reduce code coverage numbers
  • Submission does not increase alerts or messages from LGTM

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you
did and what alternatives you considered, etc...

@ronanstokes-db ronanstokes-db self-assigned this Oct 20, 2022
@lgtm-com
Copy link

lgtm-com bot commented Oct 20, 2022

This pull request introduces 1 alert when merging 51adf39 into 23a83f5 - view on LGTM.com

new alerts:

  • 1 for Unused local variable

@lgtm-com
Copy link

lgtm-com bot commented Oct 21, 2022

This pull request introduces 1 alert when merging 46f8406 into 83c5ed4 - view on LGTM.com

new alerts:

  • 1 for Unused local variable

@ronanstokes-db ronanstokes-db linked an issue Oct 21, 2022 that may be closed by this pull request
Add enhanced options and documentation for streaming data generation #115
Open
@ronanstokes-db ronanstokes-db added this to the v0.2.2 milestone Oct 22, 2022
@lgtm-com
Copy link

lgtm-com bot commented Oct 25, 2022

This pull request introduces 1 alert when merging e0f7887 into d6b1799 - view on LGTM.com

new alerts:

  • 1 for Unused local variable

@ronanstokes-db
Copy link
Contributor Author

Need to update test process to test on specific Databricks builds or open source Spark equivalent

@lgtm-com
Copy link

lgtm-com bot commented Nov 1, 2022

This pull request introduces 1 alert when merging 2b3060e into 109707e - view on LGTM.com

new alerts:

  • 1 for Unused local variable

@lgtm-com
Copy link

lgtm-com bot commented Nov 28, 2022

This pull request introduces 1 alert when merging 1b91312 into 981a5a4 - view on LGTM.com

new alerts:

  • 1 for Unused local variable

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

@ronanstokes-db ronanstokes-db modified the milestones: v0.2.2, v0.3.1 Dec 1, 2022
@ronanstokes-db
Copy link
Contributor Author

Note v0.3.1 is the release for the target version to incorporate these changes.

@ronanstokes-db ronanstokes-db marked this pull request as draft March 3, 2023 22:08
@ronanstokes-db ronanstokes-db modified the milestones: v0.3.1, v0.4.0 Mar 6, 2023
@codecov
Copy link

codecov bot commented Mar 7, 2023 •
edited

Codecov Report

Merging #127 (ab5908a) into master (bc80ef3) will decrease coverage by 1.73%.
The diff coverage is 85.49%.

❗ Current head ab5908a differs from pull request most recent head 041b3dc. Consider uploading reports for the commit 041b3dc to get more accurate results

@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
- Coverage   91.97%   90.25%   -1.73%     
==========================================
  Files          23       23              
  Lines        2680     2637      -43     
  Branches      452      438      -14     
==========================================
- Hits         2465     2380      -85     
- Misses        128      165      +37     
- Partials       87       92       +5
Impacted Files Coverage Δ
dbldatagen/data_generator.py 84.79% <82.00%> (-0.32%) ⬇️
dbldatagen/enhanced_event_time.py 96.77% <96.77%> (ø)

... and 12 files with indirect coverage changes

@ronanstokes-db ronanstokes-db marked this pull request as ready for review March 10, 2023 19:01
@CLAassistant
Copy link

CLAassistant commented Nov 27, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardwu-db howardwu-db Awaiting requested review from howardwu-db

At least 1 approving review is required to merge this pull request.

Assignees

@ronanstokes-db ronanstokes-db

Labels
None yet
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.

Add enhanced options and documentation for streaming data generation
2 participants
@ronanstokes-db @CLAassistant