Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataform run --dry-run CLI - Does not detect missing source declared in declarations #1533

Open
murlik1 opened this issue Aug 22, 2023 · 0 comments

Comments

@murlik1
Copy link

murlik1 commented Aug 22, 2023

Hi Team,
This issue is linked to closed issue #1529
The feature request is to extend the dataform compile to highlight missing source tables declared in declarations

In current case, dataform run --dry-run still goes ahead and successfully compiles the declaration even if the table declared is not existing, dataform does not actually check the resulting query to see if the table exists

This feature will help in adding CI checks by performing dataform compile.

Below is an example of declaration pointing to a non-existing table.

config {
    type: "declaration",
    database: dataform.projectConfig.vars.landing_project,
    schema:  dataform.projectConfig.vars.landing_dataset,
    name: "orders1"
}

This declaration when used in any table query, compiles without any issue. Ideally it should check the resulting query to check its validity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants