Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filepaths for actions filepaths normalized #1703

Open
Ekrekr opened this issue Mar 28, 2024 · 0 comments
Open

Filepaths for actions filepaths normalized #1703

Ekrekr opened this issue Mar 28, 2024 · 0 comments
Labels
UX Papercut

Comments

@Ekrekr
Copy link
Contributor

Ekrekr commented Mar 28, 2024 •
edited

To reproduce:

definitions/folder/actions.yaml:

actions:
- table:
    fileName: "../content.sql"

results in the compiled graph having the fileName of definitions/foleder/../content.sql for the action.

We should instead normalize the filePath (without using Node, as Core doesn't use Node).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
UX Papercut
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Ekrekr