Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug report] missing assign partitions in CapabilityHelpers #3374

Open
xiaozcy opened this issue May 13, 2024 · 4 comments · May be fixed by #3375
Open

[Bug report] missing assign partitions in CapabilityHelpers #3374

xiaozcy opened this issue May 13, 2024 · 4 comments · May be fixed by #3375
Labels
bug Something isn't working

Comments

@xiaozcy
Copy link
Contributor

xiaozcy commented May 13, 2024

Version

main branch

Describe what's wrong

Refer to #3189, I believe we are missing setting assignments in com.datastrato.gravitino.catalog.CapabilityHelpers

Error message and/or stacktrace

None

How to reproduce

None

Additional context

No response
@xiaozcy xiaozcy added the bug Something isn't working label May 13, 2024
@mchades
Copy link
Contributor

mchades commented May 13, 2024

Can you describe in detail the relationship between assignments and capability?

@xiaozcy
Copy link
Contributor Author

xiaozcy commented May 13, 2024

Can you describe in detail the relationship between assignments and capability?

In TableNormalizeDispatcher, we use applyCapabilities(partitions, capability) to wrap partition info passed by request. If we don't assign partitions in CapabilityHelpers, the table operation dispatcher would not get assignments correctly.
image

@mchades
Copy link
Contributor

mchades commented May 13, 2024

got it. Would you like to fix this?

@xiaozcy
Copy link
Contributor Author

xiaozcy commented May 13, 2024

Sure, I'll fix it later.

@xiaozcy xiaozcy linked a pull request May 13, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#3374] fix(core): set partition assignments in CapabilityHelpers xiaozcy/gravitino
2 participants
@mchades @xiaozcy