Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding time of schedule scan to Status field. #141

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Adding time of schedule scan to Status field. #141

wants to merge 2 commits into from

Conversation

sebastiancepeda
Copy link

Closes #140

@Neustradamus
Copy link

@dave-theunsub: What do you think about this PR?

@dave-theunsub
Copy link
Owner

That looks nice. I recommend changing the "at" - either leaving it out or using "@" or maybe you can think of something else. This way we don't need everyone to update the language files for the change of this one sentence as the change is minor.

@dave-theunsub
Copy link
Owner

If it's done like this, we won't need new translations:

    if ($scan) {
        $hour_spin_scan->set_value($scan_hour);
        $min_spin_scan->set_value($scan_minute);
        $scan_apply_btn->set_sensitive(FALSE);
        $scan_remove_btn->set_sensitive(TRUE);

        my $statement = _('A daily scan is scheduled');
        my ($status_line_text) =
          sprintf( "%s (%02d:%02d)", $statement, $scan_hour, $scan_minute );
        $scan_status_label->set_text($status_line_text);
    }

Anything between the _( ) portion ends up needing translation. This way we just work around it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

More information for the status field
3 participants
@sebastiancepeda @Neustradamus @dave-theunsub