New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

requires_grad = True not required for a variable under combine() method? #26

Open

doppiomovimento opened this issue Mar 22, 2024 · 0 comments

doppiomovimento commented Mar 22, 2024

Inside the combine() under SparseDispatcher, there is a line:

zeros = torch.zeros(self._gates.size(0), expert_out[-1].size(1), requires_grad=True, device=stitched.device)

It seems to me 'requires_grad=True' is not required, as 'zeros' is not any weight or parameters to be learned. Any specific reason to set it to True?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment