Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button: type is not specified in a lot of cases #2038

Open
1 of 7 tasks
mfranzke opened this issue Jan 5, 2024 · 0 comments · May be fixed by #2039
Open
1 of 7 tasks

Button: type is not specified in a lot of cases #2038

mfranzke opened this issue Jan 5, 2024 · 0 comments · May be fixed by #2039
Assignees
@mfranzke
Labels
🏘components Changes inside components folder 📕documentation Improvements or additions to documentation
Milestone
Guidelines 3.0 RC

Comments

@mfranzke
Copy link
Member

mfranzke commented Jan 5, 2024

Which generators are impacted?

  • All
  • HTML
  • React
  • Angular
  • Vue
  • Web components
  • Power Apps

Reproduction case

Currently the buttons type is not specified in a lot of places, whereas this would lead to that a submit type (default) would get presumed.

Expected Behaviour

Buttons of type button should actually get that attribute defined.

Screenshots

No response

Browser version

None

Add any other context about the problem here.

No response
@mfranzke mfranzke added 📕documentation Improvements or additions to documentation 🏘components Changes inside components folder labels Jan 5, 2024
@mfranzke mfranzke added this to the Guidelines 3.0 Beta milestone Jan 5, 2024
@mfranzke mfranzke self-assigned this Jan 5, 2024
@mfranzke mfranzke linked a pull request Jan 5, 2024 that will close this issue
Draft
5 tasks
@mfranzke mfranzke linked a pull request Jan 5, 2024 that will close this issue
refactor: define the button elements type #2039
Draft
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mfranzke mfranzke

Labels
🏘components Changes inside components folder 📕documentation Improvements or additions to documentation
Projects
None yet
Milestone
Guidelines 3.0 RC
Development

Successfully merging a pull request may close this issue.

refactor: define the button elements type db-ui/mono
1 participant
@mfranzke