Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: create a check-model-has-labels-keys for dbt with BigQuery #136

Open
gabrielcber opened this issue Jun 21, 2023 · 0 comments
Open
Labels
enhancement New feature or request priority: high

Comments

@gabrielcber
Copy link

gabrielcber commented Jun 21, 2023

Describe the feature you'd like
dbt-checkpoint is great and the check-model-has-meta-keys is optimal to enforce Data Governance labels that we need in a big dbt project such as one with a data mesh architecture. With BigQuery, dbt gives us the possibility to assign also a list of keys to a dictionary called labels and this keys will be passed to BigQuery and they also will be assigned to the table in the Data Warehouse.

The idea here is to create a hook to enforce the labels keys to be filled, instead of the meta keys.

Additional context
I've tried to implement myself the hook by changing all the occurrences of "meta" in the check-model-has-meta-keys.py file for "labels", but it obviously didn't work as expected. After adding it to the setup.cfg and .pre-commit-hooks.yaml files, I encounter the following error:

image

So the conclusion is that I would like help to implement that, if it is possible somehow. I think it is a good feature for BigQuery + dbt users.

@gabrielcber gabrielcber added the enhancement New feature or request label Jun 21, 2023
johnerick-py added a commit to johnerick-py/dbt-checkpoint that referenced this issue Aug 11, 2023
…creating a new hook for labels, I tested it in a production environment where I call the hook to validate the model and everything is ok, but in the dbt-checkpoint repository I am having difficulties solving the unit tests , I will be grateful for any help or comments about.
BAntonellini added a commit that referenced this issue Dec 21, 2023
* this feature seeks to solve the problem of issue #136
* Add documentation and setup of new hooks

---------

Co-authored-by: johnerick-py <johnerick-py@users.noreply.github.com>
Co-authored-by: Bruno Antonellini <antonellinibruno@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority: high
Projects
None yet
Development

No branches or pull requests

2 participants