Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CT-2786] Remove "legacy logger" #8027

Closed
Tracked by #4
, #9099
...
jtcohen6 opened this issue Jul 4, 2023 · 7 comments · Fixed by #10119
Closed
Tracked by #4
, #9099
...

[CT-2786] Remove "legacy logger" #8027

jtcohen6 opened this issue Jul 4, 2023 · 7 comments · Fixed by #10119
Assignees
@emmyoop @MichelleArk @colin-rogers-dbt
Labels
logging tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality
Milestone
v1.9

Comments

@jtcohen6
Copy link
Contributor

jtcohen6 commented Jul 4, 2023 •
edited by martynydbt

Acceptance criteria:

  • Remove logger.py in its entirety
  • It's being imported in a handful of places, for some small utilities. Let's either move 'em or lose 'em.
  • Remove pytest-logbook from dev-requirements.txt in dbt-core and adapter repos
@jtcohen6 jtcohen6 added this to the v1.7 milestone Jul 4, 2023
@jtcohen6 jtcohen6 added tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality logging labels Jul 4, 2023
@github-actions github-actions bot changed the title Remove "legacy logger" [CT-2786] Remove "legacy logger" Jul 4, 2023
@jtcohen6 jtcohen6 mentioned this issue Jul 4, 2023
Open
1 task
@graciegoheen
Copy link
Contributor

Some slight complication (from estimation meeting): we have some context managers in place in order to setup the legacy logger which will need to be removed as well

@graciegoheen graciegoheen removed this from the v1.7 milestone Sep 26, 2023
@MichelleArk MichelleArk mentioned this issue Nov 6, 2023
Merged
5 tasks
@jtcohen6 jtcohen6 mentioned this issue Nov 7, 2023
Closed
@jtcohen6
Copy link
Contributor Author

jtcohen6 commented Dec 5, 2023

Resolved by #8989

@jtcohen6 jtcohen6 closed this as completed Dec 5, 2023
@jimmymaise
Copy link

Still have logbook package?

@emmyoop emmyoop mentioned this issue Jan 9, 2024
Merged
5 tasks
@emmyoop
Copy link
Member

emmyoop commented Jan 9, 2024

logger.py wasn't removed and we're still depending on logbook. Reopening the issue.

@emmyoop emmyoop reopened this Jan 9, 2024
@emmyoop emmyoop self-assigned this Jan 9, 2024
This was referenced Jan 9, 2024
Open
Open
@emmyoop
Copy link
Member

emmyoop commented Jan 11, 2024

Resolved by #9353

@emmyoop emmyoop closed this as completed Jan 11, 2024
@emmyoop
Copy link
Member

emmyoop commented Jan 12, 2024

Backing out these changes for now as cloud still has a codepath dependent on it. Will revisit.

@emmyoop emmyoop reopened this Jan 12, 2024
@martynydbt martynydbt added this to the v1.8 milestone Feb 12, 2024
@NickMacroRoot
Copy link

Is there any timeline on getting this implemented? I have a use case where it requires binary only installation and logbook is blocking it.

@MichelleArk MichelleArk mentioned this issue May 6, 2024
Open
@emmyoop emmyoop mentioned this issue May 9, 2024
Merged
5 tasks
@jtcohen6 jtcohen6 modified the milestones: v1.8, v1.9 May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emmyoop emmyoop

@MichelleArk MichelleArk

@colin-rogers-dbt colin-rogers-dbt

Labels
logging tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality
Projects
None yet
Milestone
v1.9
Development

Successfully merging a pull request may close this issue.

remove logbook dbt-labs/dbt-core
9 participants
@peterallenwebb @emmyoop @MichelleArk @jtcohen6 @jimmymaise @graciegoheen @NickMacroRoot @colin-rogers-dbt @martynydbt