Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove findBy from save at BookRepository.save(Book book) #54

Open
pilloPl opened this issue Mar 19, 2020 · 0 comments
Open

Remove findBy from save at BookRepository.save(Book book) #54

pilloPl opened this issue Mar 19, 2020 · 0 comments

Comments

@pilloPl
Copy link
Member

pilloPl commented Mar 19, 2020

 @Override
    public void save(Book book) {
        findBy(book.bookId())
                .map(entity -> updateOptimistically(book))
                .onEmpty(() -> insertNew(book));
    }

this findBy is only there to have updateOrCreate behavior. But it makes optimistic locking doesn't work. in FindBy we fetch new Version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant