Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DiffToTarget needs to support non-whole number difficulties #140

Open
jolan opened this issue Feb 15, 2017 · 1 comment
Open

DiffToTarget needs to support non-whole number difficulties #140

jolan opened this issue Feb 15, 2017 · 1 comment
Labels
bug

Comments

@jolan
Copy link

jolan commented Feb 15, 2017

We didn't think non-whole number difficulties were very common except when using underpowered GPUs but the traces by @unintuitive in #135 make it clear that some pools use them more frequently.

Maybe just rounding up or down would be an improvement.
@jolan jolan added the bug label Feb 15, 2017
@jcvernaleo jcvernaleo mentioned this issue Feb 17, 2017
Merged
@jolan jolan added this to the v0.9.0 milestone Feb 20, 2017
@jolan jolan removed this from the v1.0.0 milestone Jan 26, 2018
@jolan
Copy link
Author

jolan commented Jan 26, 2018

I don't think the pools were doing strict difficulty checking before because the "round the difficulty down" hack we went with is causing a lot more rejected shares these days.

Since this is supposed to be the reference miner and all, a proper solution should really be implemented.

@jolan jolan reopened this Jan 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jcvernaleo @jolan