Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fatal log removed #5043

Merged
merged 22 commits into from May 20, 2024
Merged

fix: fatal log removed #5043

merged 22 commits into from May 20, 2024

Conversation

ShashwatDadhich
Copy link
Contributor

@ShashwatDadhich ShashwatDadhich commented May 2, 2024 •
edited

Description

log.fatal removed

Fixes #5054

How Has This Been Tested?

  • Tested locally
  • Tested by deploying in VM.

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

@ShashwatDadhich ShashwatDadhich changed the title log.Fatal Removed chore: fatal log removed May 2, 2024
@ShashwatDadhich ShashwatDadhich changed the title chore: fatal log removed fix: fatal log removed May 2, 2024
nishant-d
nishant-d requested changes May 3, 2024
View reviewed changes
fetchAllEnv/fetchAllEnv.go Show resolved Hide resolved
pkg/auth/authorisation/casbin/Adapter.go Outdated Show resolved Hide resolved
pkg/clusterTerminalAccess/UserTerminalAccessService.go Outdated Show resolved Hide resolved
pkg/module/ModuleCacheService.go Show resolved Hide resolved
nishant-d
nishant-d requested changes May 3, 2024
View reviewed changes
client/argocdServer/connection/proxy.go Outdated Show resolved Hide resolved
nishant-d
nishant-d requested changes May 7, 2024
View reviewed changes
client/grafana/proxy.go Outdated Show resolved Hide resolved
pkg/module/ModuleCacheService.go Show resolved Hide resolved
pkg/server/ServerCacheService.go Show resolved Hide resolved
nishant-d
nishant-d previously approved these changes May 9, 2024
View reviewed changes
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 20, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
8.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@ShashwatDadhich ShashwatDadhich merged commit 18d0aaa into main May 20, 2024
7 of 8 checks passed
@ShashwatDadhich ShashwatDadhich deleted the logger_handeled branch May 20, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nishant-d nishant-d nishant-d approved these changes

@vikramdevtron vikramdevtron Awaiting requested review from vikramdevtron vikramdevtron is a code owner

@kripanshdevtron kripanshdevtron Awaiting requested review from kripanshdevtron kripanshdevtron is a code owner

Assignees
No one assigned
Labels
PR:Ready-to-Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Remove log.Fatal
2 participants
@ShashwatDadhich @nishant-d