Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Api to make deployment template override for env of Devtron application #5096

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

fix: Api to make deployment template override for env of Devtron application #5096

wants to merge 22 commits into from

Conversation

ShashwatDadhich
Copy link
Contributor

@ShashwatDadhich ShashwatDadhich commented May 10, 2024 •
edited

Description

Fix for Api to make deployment template override for env of Devtron application

Fixes #5091

How Has This Been Tested?

  • Tested locally
  • Tested by deploying in VM.

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

@ShashwatDadhich ShashwatDadhich changed the title Environment Override case handled for environment patch fix: Api to make deployment template override for env of Devtron application May 10, 2024
nishant-d
nishant-d requested changes May 12, 2024
View reviewed changes
api/restHandler/app/pipeline/configure/DeploymentPipelineRestHandler.go Outdated
return
}
if envConfigProperties == nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use if else here

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nishant-d nishant-d nishant-d requested changes

@vikramdevtron vikramdevtron Awaiting requested review from vikramdevtron vikramdevtron is a code owner

@kripanshdevtron kripanshdevtron Awaiting requested review from kripanshdevtron kripanshdevtron is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
PR:Ready-to-Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Api to make deployment template override for env of Devtron application
2 participants
@ShashwatDadhich @nishant-d