Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot save Character (.dch) changes directly from Dialogic edit panel, can force save in scene 2D/3D view or by playing but then asterisk remains #2227

Open
hsandt opened this issue May 14, 2024 · 5 comments
Labels
Bug 🐞 Something isn't working Needs testing We don't understand this problem fully yet

Comments

@hsandt
Copy link

hsandt commented May 14, 2024

The problem

Describe the bug
After editing a character property e.g. Display Name and pressing Ctrl+S, the character is not saved (can be verified in git diff) (behavior bug) and the dirty asterisk remains visible (that is not an extra bug and shows reality).

I found 3 ways to force save:

  • Switch to 2D/3D scene view and save. git diff can confirm. However, when coming back to character view in Dialogic panel, if you didn't switch view to another character/timeline, the asterisk will remain (until you switch to another entity and back to that character). (visual bug)
  • Play the game will auto-save before. git diff can confirm. However, same issue as above, you didn't refresh view and * is still visible. (visual bug)
  • Switch to another Dialogic entity e.g. timeline and save. In this case you changed view inside Dialogic so when you come back to character, asterisk is cleared (no bug)

To Reproduce
Steps to reproduce the behavior:

  1. Open Dialogic panel and Create new character
  2. Change some property e.g. Display Name
  3. Ctrl+S to save => no save at all
  4. Variant 1: switch to another view (outside Dialogic) and save => saved, but asterisk remains when coming back
  5. Variant 2: play => saved, but asterisk remains

Expected behavior
Character changes should be saved

Screenshots

image

System (please complete the following information):

  • OS: Linux Ubuntu 22.04
  • Godot Version: v4.2.1.stable.official [b09f793f5]
  • Dialogic Version: main commit a9c56aa (2024-05-05)
@hsandt
Copy link
Author

hsandt commented May 14, 2024

I got a similar issue with Dialogic Settings but there is no dirty asterisk at all. I may open another issue for this one if I find the exact conditions.

@CakeVR
Copy link
Collaborator

CakeVR commented May 14, 2024

Make sure that the version you use is the one from the main branch. Alpha 13 is very outdated by now.

@hsandt
Copy link
Author

hsandt commented May 15, 2024

Apparently I was in fact using main commit a9c56aa from 2024-05-05. Only 5 commits have been done since, including some to fix bugs I opened recently. I updated Dialogic version in my OP.

@AnidemDex
Copy link
Contributor

I found something related while doing some tests with b14d635 in 4.3: Dialogic marks the scene state as modified/unsaved when loading (not even editing) any of its resources

@Jowan-Spooner
Copy link
Collaborator

This is strange, saving characters with CTRL+S works for me.

@Jowan-Spooner Jowan-Spooner added Bug 🐞 Something isn't working Needs testing We don't understand this problem fully yet labels May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐞 Something isn't working Needs testing We don't understand this problem fully yet
Projects
None yet
Development

No branches or pull requests

4 participants