Only generate WordPress config for domains with WordPress enabled #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattIPv4
reviewed
Oct 5, 2023
| @@ -64,7 +64,8 @@ export default (domains, global) => { | |||
| files[`${sitesDir}/${domain.server.domain.computed}.conf`] = toConf(websiteConf(domain, domains, global, ipPortPairs)); | |||
| // WordPress | |||
| if (domains.some(d => d.php.wordPressRules.computed)) | |||
There was a problem hiding this comment.
I think this if statement is redundant now?
MattIPv4
changed the title
|
👋 Any update on this @MrJmpl3? |
|
Closing due to lack of movement, outstanding review comments + conflicts. Please let me know if you'd like help getting this landed :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Generation of configuration
What issue does this relate to?
Resolves #435
What should this PR do?
Fix the issue #435 by switching the generation for the WordPress config to only happen on domains with WordPress, rather than all domains when any domain has WordPress.
What are the acceptance criteria?
The pull request need fix the issue and cannot break the app
Please, tag this pull request to make a point in Hacktoberfest 2023