Why the API keys are now through DB and not through an .env?

[Seedfy]

Hi,

I would like to ask the reason why now the api keys are into the db. Isn't that less secure that having them outside the DB on an environment file?

[arnav13081994]

We have added support for multiple stripe accounts and it's way easier to add related APIKeys through admin.

[Seedfy]

I accept the answer, but this is not the right way of solving this.

Following the third of the twelve-factor app standards, this is a bad praxis because we should be able to manage all the configurations through an environment, not through the database.

Also, as far as I understand, doesn't allow the platforms using this package to acquire the certification ISO 27001. And that is a deal breaker.

[jleclanche]

Hi @Seedfy! Thanks for raising this.

Arnav already explained the surface-level "why": We need this structure in order to support multiple accounts. Beyond that, we also need this to support dynamically adding and removing accounts.

There is discussion going as far back as 2.4.0 regarding this:
#1265 (comment)

To make it short, the Stripe API key is not "configuration" for us, it's state. But it is very sensitive state. I'm happy to hear how you would improve on this, while retaining the ability to do stateful, dynamic set up of accounts, webhooks, etc.

Re ISO 27001, certification is still possible, but indeed it's a little more difficult. You will be expected, among other things, to use at-rest encryption of the database. Honestly, for a billing database, this is something you should already be doing.

I would also invite you to visit our sponsorships page, as we offer more direct support for this level of assistance through there, including custom development. If you need help with your ISO 27001 certification, my own company offers consulting assistance for this kind of thing. Feel free to contact me directly.