Made get_remote_ip func swappable by exposing a new setting #1537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
-1, this is not worth a new setting. |
|
@jleclanche How do you suggest we allow the user to handle customising the |
jleclanche
force-pushed
the
master
branch
6 times, most recently
from
a0de35c
to
2e0eead
Compare
arnav13081994
force-pushed
the
make_remote_ip_func_swappable
branch
from
38584a4
to
53cee08
Compare
Renamed get_remote_ip() to _get_remote_ip() to avoid any confusion with the externally exposed setting
arnav13081994
force-pushed
the
make_remote_ip_func_swappable
branch
from
53cee08
to
61371c9
Compare
…ustomizable This was done so that users can use a setup that may better meet their needs as mentioned in dj-stripe#1057.
…etting DJSTRIPE_GET_REMOTE_IP
arnav13081994
force-pushed
the
make_remote_ip_func_swappable
branch
from
61371c9
to
acd5cdd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please merge PR #1531 before merging this
Description
This PR contains the following changes:
DJSTRIPE_GET_REMOTE_IPto allow the user to write their own function to extract theremote_ipfrom therequest.Checklist:
testsor confirm that my change doesn't require any updates.documentationor confirm that my change doesn't require any updates.migrationsor confirm that my change doesn't make changes to any model.Rationale
Fix: #1057
Fix: #1843
User would now be able to override
_get_remote_ipwith their own function for more advanced setups and perhaps even use libraries like django-ipware