Bug in calculating max buffer size

[zaycev]

Crate versions
This is critical, please fill. The code is evolving fast, and many bugs get fixed. If you're not on latest please try first on latest release if you can, chances are the bug is fixed there.
bevy version: 0.11.3
bevy_hanabi version: 33936ee944913fd6a4ba8bf55116508bc3f7057c

Describe the bug

wgpu error: Validation Error

Caused by:
    In a RenderPass
      note: encoder = `<CommandBuffer-(0, 731, Vulkan)>`
    In a set_bind_group command
      note: bind group = `<BindGroup-(1531, 1, Vulkan)>`
    Dynamic binding offset index 1 with offset 209920 would overrun the buffer bound to bind group 1 -> binding 3. Buffer size is 209920 bytes, the binding binds bytes 0..624, meaning the maximum the binding can be offset is 209296 bytes

[djeedai]

Thanks @zaycev. Do you have more info on how to reproduce? I'm afraid I can't do much as is. I'm also a bit surprised that neither the encoder not the bind group have a name, normally all Hanabi GPU resources are named to help debugging. The version you're using is also kind of old, if you can upgrade that would be better (Bevy 0.13 is getting out soon).

[zaycev]

Thanks @zaycev. Do you have more info on how to reproduce? I'm afraid I can't do much as is. I'm also a bit surprised that neither the encoder not the bind group have a name, normally all Hanabi GPU resources are named to help debugging. The version you're using is also kind of old, if you can upgrade that would be better (Bevy 0.13 is getting out soon).

Thank you for taking a look. I will try to provide more context as I'm debugging this. The error is actually coming from core_2d pipeline, but only when hanabi is included into project.

[zaycev]

It seems to be related to the amount of emitter batches. After I fixed the issue with 2D culling, the issue does not repro anymore. I will try to create a similar setup in one the examples and see if I can cause bevy to crash.

[djeedai]

Ok thanks. Wild guess, it sounds like there's a missing bounds check somewhere when some container becomes full.