other: POSTMASTER_ADDRESS in 15-lda.conf

[jsonn]

Subject

Something else that requires developers attention

Description

In the main Dockerfile (

docker-mailserver/Dockerfile

Line 99 in 2018be7

sedfile -i -e 's/^.*postmaster_address.*/postmaster_address = '${POSTMASTER_ADDRESS:="postmaster@domain.com"}'/g' /etc/dovecot/conf.d/15-lda.conf

) 15-lda.conf is currently patched to contain the value of POSTMASTER_ADDRESS with a fallback value. It's not clear to me how this is supposed to ever work:

1. The environment variable is not set at this point in the build environment.
2. The line is replaced with the correct runtime value anyway (

   docker-mailserver/target/scripts/startup/setup.d/dovecot.sh

   Line 12 in 2018be7

   sedfile -i 's|^postmaster_address = .*$|postmaster_address = '"${POSTMASTER_ADDRESS}"'|g' /etc/dovecot/conf.d/15-lda.conf

   )

Is there any point left in doing the change in the main Dockerfile?

[polarathene]

Is there any point left in doing the change in the main Dockerfile?

No, it should be removed. v14 changed Debian image and carries a bunch of other changes, so refactoring the Dockerfile has been delayed to a release after that.

There's a lot in there that can be pulled out into a separate build script like we do with packages.sh and compile.sh.

Regarding postmaster, it has a variety of concerns to address: #3769

[github-actions]

This issue has become stale because it has been open for 20 days without activity.
This issue will be closed in 10 days automatically unless:

• a maintainer removes the meta/stale label or adds the stale-bot/ignore label
• new activity occurs, such as a new comment