Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for seekable stream for malformed uri handling #1644

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Check for seekable stream for malformed uri handling #1644

merged 2 commits into from
Jan 9, 2024

Conversation

twsouthwick
Copy link
Member

  • We must be able to seek to create a temporary file requried for uri handling
  • We should throw the same exception we did in v2.x
  • If compat mode is on, this will throw at open time (i.e. it will eagerly load everything)

Fixes #1636

@twsouthwick
Check for seekable stream for malformed uri handling
cdac38f 
- We must be able to seek to create a temporary file requried for uri handling
- We should throw the same exception we did in v2.x
- If compat mode is on, this will throw at open time (i.e. it will eagerly load everything)

Fixes #1636
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2024 •
edited

Test Results

    70 files  ± 0      70 suites  ±0   1h 5m 17s ⏱️ + 6m 1s
 2 028 tests + 6   2 025 ✅ + 6   3 💤 ±0  0 ❌ ±0 
32 262 runs  +72  32 226 ✅ +72  36 💤 ±0  0 ❌ ±0 

Results for commit 01c6f0a. ± Comparison against base commit 3e35208.

♻️ This comment has been updated with latest results.

@twsouthwick twsouthwick merged commit 4f67359 into main Jan 9, 2024
22 checks passed
@twsouthwick twsouthwick deleted the malformed branch January 9, 2024 02:35
@twsouthwick twsouthwick mentioned this pull request Jan 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug with Open XML SDK v3.0 and excels with malformed hyperlinks
1 participant
@twsouthwick