Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use C# pattern matching for matching types. #25

Open
imback82 opened this issue Jan 15, 2019 · 0 comments · May be fixed by #1003
Open

Use C# pattern matching for matching types. #25

imback82 opened this issue Jan 15, 2019 · 0 comments · May be fixed by #1003
Labels
good first issue Good for newcomers

Comments

@imback82
Copy link
Contributor

There are many places where we are doing the following:
PayloadHelper.GetTypeId():

        if (type == typeof(int))
        {
            return new[] { Convert.ToByte('i') };
        }
        if (type == typeof(long))
        {
            return new[] { Convert.ToByte('g') };
        }
        ..

Use C#'s pattern matching instead if applicable.
@rapoth rapoth transferred this issue from another repository Apr 24, 2019
@rapoth rapoth added the good first issue Good for newcomers label Apr 24, 2019
This was referenced Aug 20, 2020
Closed
Merged
This was referenced Sep 1, 2020
Merged
Closed
@SARAVANA1501 SARAVANA1501 mentioned this issue Oct 9, 2020
Merged
sneznaj added a commit to sneznaj/spark that referenced this issue Dec 2, 2021
@sneznaj
Use pattern matching in PayloadHelper.cs to improve readability
1a059d5 
Improves the readability using c# pattern matching
fixes dotnet#25
@sneznaj sneznaj linked a pull request Dec 2, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use pattern matching in PayloadHelper.cs to improve readability sneznaj/spark
2 participants
@rapoth @imback82