Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support YugabyteDB as a dataprovider #1591

Open
ccorbacho opened this issue Apr 16, 2024 · 1 comment
Open

Support YugabyteDB as a dataprovider #1591

ccorbacho opened this issue Apr 16, 2024 · 1 comment
Labels
suggestion Feature suggestion

Comments

@ccorbacho
Copy link

Is your feature request related to a problem? Please describe.

Sftpgo has dataprovider support for both Postgres, and CockroachDB (which providers a PG interface, and sftpgo uses a subset of the PG SQL to implement it).

YugabyteDB also provides a Postgres interface, but unlike CockroachDB, it does not yet support GIST indexes, and therefore does not support any indexes on INET type fields. This means the DB schema creation fails on the final CREATE INDEX step when it tries to create the index on the "first" and "last" columns.

Describe the solution you'd like

Add a new dataprovider type, "yugabytedb", following the same pattern as the "cockroachdb" provider - update pgsql.go to add this as a new variant of postgres, by excludiung the same SQL from yugabytedb as cochroachdb, but also exclude creating the index for ip_lists_first_last_idx from "yugabytedb" (i.e. only create this index on cockroachdb and postgresql).

Describe alternatives you've considered

No response

What are you using SFTPGo for?

Medium business

Additional context

No response

@ccorbacho ccorbacho added the suggestion Feature suggestion label Apr 16, 2024
@drakkan
Copy link
Owner

drakkan commented Apr 28, 2024

This will increase the maintenance burden, similar to CockroachDB (which we are considering removing) as every time we modify the db we have to do specific tests and add different code paths to be compatible with these variants.

It can be added if requested by companies that support SFTPGo in the long term and thus make this increased maintenance burden sustainable. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
suggestion Feature suggestion
Projects
None yet
Development

No branches or pull requests

2 participants