Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.9.4 breaks some Typescript configurations #1635

Open
1 task done
djMax opened this issue Apr 27, 2024 · 3 comments
Open
1 task done

0.9.4 breaks some Typescript configurations #1635

djMax opened this issue Apr 27, 2024 · 3 comments
Labels
bug Something isn't working openapi-fetch Relevant to the openapi-fetch library

Comments

@djMax
Copy link

djMax commented Apr 27, 2024

Description

Something in the changes in 0.9.4 causes NodeNext module resolution to fail.

#1634

Reproduction

Node.js side, but build time so no reason browser wouldn't also be affected. I can't get the playground to fail because I don't have full control of tsconfig it seems, but here's what fails in a local build with specific tsconfig values (as described in the discussion):

Playground

Expected result

URLs should be "known" but end up just being ignored/allow any value.

Checklist

@djMax djMax added bug Something isn't working openapi-fetch Relevant to the openapi-fetch library labels Apr 27, 2024
@drwpow
Copy link
Owner

drwpow commented Apr 28, 2024

Thanks for the investigation! Looking into it. It could have something to do with a change to openapi-typescript-helpers. I think I’m going to add tests for different moduleResolutions somehow. Could or could not be the problem based on #1634, but couldn’t hurt to eliminate that as a possibility. This seems like a bug, as TSConfig settings shouldn’t affect type safety.

@djMax
Copy link
Author

djMax commented Apr 28, 2024

Let me know if I can help - I had a sniff that the helpers might be involved too but I couldn't quite see how. There are a number of typing related changes in there, so it's a bit beyond my limited current understanding of the type infra here.

@djMax
Copy link
Author

djMax commented May 19, 2024

Is this theoretically fixed? I think it is but I have only seen that the playground errors now (as it should). But before I go through the variety of deps to update would love to know it was intentional :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working openapi-fetch Relevant to the openapi-fetch library
Projects
None yet
Development

No branches or pull requests

2 participants