Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better PageControl for Swift #161

Open
oenama opened this issue May 1, 2016 · 2 comments
Open

Better PageControl for Swift #161

oenama opened this issue May 1, 2016 · 2 comments

Comments

@oenama
Copy link

oenama commented May 1, 2016

http://stackoverflow.com/q/36965228/4837354

@ealeksandrov
Copy link
Owner

Good catch. Try looking for custom page controls that are subclasses of UIPageControl.

I'll update demo when I have time.

@ealeksandrov
Copy link
Owner

After looking through this - there is no ability to effectively subclass UIPageControl so we need to ultimately choose some particular custom PageControl that will suit all our customization needs.

Since there is no good open-source solution (SMPageControl is not maintained) - I will return to choosing/creating dependency when rewriting EAIntroView in Swift.

For obj-c SMPageControl hack is ok but I don't recommend it for Swift. I won't add SMPageControl as dependency now as I don't think that it is needed for most of users and others can use current workaround.

@ealeksandrov ealeksandrov changed the title change page Indicator Image [SMPageControl] / EAIntroView in swift Better PageControl for Swift Nov 5, 2016
ealeksandrov added a commit that referenced this issue Nov 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants