Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Buffer toJson method to toJsonElement #5062

Open
vietj opened this issue Jan 12, 2024 · 0 comments
Open

Rename Buffer toJson method to toJsonElement #5062

vietj opened this issue Jan 12, 2024 · 0 comments
Milestone

Comments

@vietj
Copy link
Member

vietj commented Jan 12, 2024

The Buffer#toJson method is incorrectly named as it operates like toJsonObject/toJsonArray : it interprets the content of the buffer and returns a corresponding json element.

Data object toJson methods instead transform the current object into a JSON representation, for buffer that would be a base64 representation of its bytes.

This method will be renamed to toJsonElement in master and deprecated in 4.x

@vietj vietj added this to the 5.0.0 milestone Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant