Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename SharedMemory* types to Shm* #1014

Closed
yellowhatter opened this issue May 6, 2024 · 3 comments · Fixed by #1095
Closed

Rename SharedMemory* types to Shm* #1014

yellowhatter opened this issue May 6, 2024 · 3 comments · Fixed by #1095
Labels
api fix Correct API release Part of the next release

Comments

@yellowhatter
Copy link
Contributor

Describe the release item

In order to shorten type names as we did with ZSliceShm -> ZShm, I propose to do SharedMemory* -> Shm* renaming.
@yellowhatter yellowhatter added the release Part of the next release label May 6, 2024
@yellowhatter
Copy link
Contributor Author

@Mallets what would you say?

@Mallets
Copy link
Member

Mallets commented May 6, 2024

I think it's ok to rename it to a shorter name. shm is already an established short version of shared memory.

@milyin milyin added the api fix Correct API label May 30, 2024
@milyin milyin linked a pull request Jun 9, 2024 that will close this issue
massive renaming for shm #1095
Merged
@Mallets
Copy link
Member

Mallets commented Jun 11, 2024

Closed by #1095

@Mallets Mallets closed this as completed Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api fix Correct API release Part of the next release
Projects
Zenoh 1.0.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

massive renaming for shm ZettaScaleLabs/zenoh
3 participants
@milyin @Mallets @yellowhatter