Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make rx task close the link properly in low-latency transport #1030

Merged
merged 1 commit into from
May 30, 2024
Merged

fix: make rx task close the link properly in low-latency transport #1030

merged 1 commit into from
May 30, 2024

Conversation

YuanYuYuan
Copy link
Contributor

Closes #1024.

@YuanYuYuan YuanYuYuan mentioned this pull request May 15, 2024
Closed
@esemeniuc
Copy link

Tested this branch with udp (no lowlatency settings), still misses connections

@esemeniuc
Copy link

TCP with lowlatency looks good

@Mallets
Copy link
Member

Mallets commented May 28, 2024

@yellowhatter could you please have a look at this PR?

yellowhatter
yellowhatter approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@yellowhatter yellowhatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Mallets Mallets merged commit 009f666 into eclipse-zenoh:main May 30, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yellowhatter yellowhatter yellowhatter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Zenoh fails to reconnect when running with lowlatency and without scouting/gossip
4 participants
@YuanYuYuan @esemeniuc @Mallets @yellowhatter