Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stabby 4.0.5 does not pass the CI #1034

Closed
fuzzypixelz opened this issue May 17, 2024 · 1 comment
Closed

stabby 4.0.5 does not pass the CI #1034

fuzzypixelz opened this issue May 17, 2024 · 1 comment
Labels
dependencies Pull requests that update a dependency file release Part of the next release

Comments

@fuzzypixelz
Copy link
Member

Describe the release item

stabby 4.0.5 doesn't pass Clippy lints from Rust 1.78:

error[E0492]: constants cannot refer to interior mutable data
  --> /Users/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/stabby-abi-4.0.5/src/vtable.rs:66:44
   |
66 |       const VTABLE: &'a VTable<Head, Tail> = &VTable {
   |  ____________________________________________^
67 | |         head: *Head::VTABLE,
68 | |         tail: *Tail::VTABLE,
69 | |     };
   | |_____^ this borrow of an interior mutable value may end up in the final value

error[E0492]: constants cannot refer to interior mutable data
   --> /Users/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/stabby-abi-4.0.5/src/vtable.rs:169:36
    |
169 |     const VTABLE: &'a VtSend<Vt> = &VtSend(*Vt::VTABLE);
    |                                    ^^^^^^^^^^^^^^^^^^^^ this borrow of an interior mutable value may end up in the final value

error[E0492]: constants cannot refer to interior mutable data
   --> /Users/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/stabby-abi-4.0.5/src/vtable.rs:180:36
    |
180 |     const VTABLE: &'a VtSync<Vt> = &VtSync(*Vt::VTABLE);
    |                                    ^^^^^^^^^^^^^^^^^^^^ this borrow of an interior mutable value may end up in the final value

This is fixed in stabby 5.0.0, however its usage may raise performance issues.

The path of least resistance is to set the Clippy version in the CI to 1.77.

@fuzzypixelz fuzzypixelz added the release Part of the next release label May 17, 2024
@yellowhatter
Copy link
Contributor

Fixed in #1045

5.x.x performance issues do not affect as we do not use the affected functionality.

@milyin milyin added the dependencies Pull requests that update a dependency file label May 30, 2024
@milyin milyin closed this as completed Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file release Part of the next release
Projects
Status: Done
Development

No branches or pull requests

3 participants