Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protocol changes: Refactor Liveliness implementation #864

Open
fuzzypixelz opened this issue Mar 26, 2024 · 0 comments · May be fixed by #865
Open

Protocol changes: Refactor Liveliness implementation #864

fuzzypixelz opened this issue Mar 26, 2024 · 0 comments · May be fixed by #865
Assignees
Labels
enhancement Existing things could work better release Part of the next release

Comments

@fuzzypixelz
Copy link
Member

fuzzypixelz commented Mar 26, 2024

A Zenoh application that declares a Liveliness token is monitored internally as if it were a subscriber. However, today the Zenoh protocol defines messages for declaring/undeclaring a "token".

The scope of this issue is to refactor the Liveliness implementation to use DeclareToken/UndeclareToken messages instead of DeclareSubscriber/UndeclareSubscriber messages.

The main motivator for this is the current interaction between the Liveliness feature and the aggregation configuration option, where a user could technically aggregate subscribers under @/liveliness/** which means that a Liveliness subscriber would not be able to distinguish between different monitored Zenoh applications.

@fuzzypixelz fuzzypixelz added the release Part of the next release label Mar 26, 2024
@fuzzypixelz fuzzypixelz linked a pull request Mar 26, 2024 that will close this issue
@OlivierHecart OlivierHecart changed the title Refactor Liveliness implementation Protocol changes: Refactor Liveliness implementation Mar 26, 2024
@OlivierHecart OlivierHecart added the enhancement Existing things could work better label Mar 26, 2024
@OlivierHecart OlivierHecart linked a pull request Mar 26, 2024 that will close this issue
@OlivierHecart OlivierHecart removed their assignment Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Existing things could work better release Part of the next release
Projects
Status: In progress
Development

Successfully merging a pull request may close this issue.

2 participants