Fix zenoh-c DLL crash in libc::atexit handler
#970
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tries to fix #973.
If I understand correctly, the reason for using threads here is to optimize the destructor, but the cost of spawning threads is usually too high. I tried to measure the execution time of this destructor and got 400µs. If we use one thread to shutdown all runtimes this actually drops (pun intended) down to 20µs. And it resolves the above panic. This is what the pull request does, in addition to decreasing the shutdown timeout to 1ms. The shutdown threads are used because one supposedly cannot callshutdown_timeout()from the same thread that was used to create the runtime.