feat(product-card): add stamp new #533
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leomp12
requested changes
Sep 11, 2021
Comment on lines
+47
to
+62
| &__new-stamp { | ||
| background-color: var(--info); | ||
| color: var(--info-yiq); | ||
| min-width: 55px; | ||
| font-size: 80%; | ||
| line-height: 2.2; | ||
| text-align: center; | ||
| position: absolute; | ||
| z-index: 9; | ||
| top: 1rem; | ||
| left: 0; | ||
| border-radius: var(--border-radius); | ||
| transition: border-radius .3s; | ||
| opacity: .9; | ||
| font-weight: var(--font-bold); | ||
| } |
There was a problem hiding this comment.
Tá duplicando todos os estilos do &__offer-stamp 😐
Os estilos que eles compartilham deveriam ser escritos uma vez só:
&__offer-stamp,
&__new-stamp {
// estilos compartilhados
}
&__offer-stamp {
// só do offer stamp
}
&__new-stamp {
// só do new stamp
}
Comment on lines
+126
to
+128
| const today = new Date() | ||
| const createdAt = new Date(body.created_at) | ||
| const differenceDates = today.getTime() - createdAt.getTime() |
There was a problem hiding this comment.
Não precisa criar uma instância Date today pra pegar o timestamp corrente, Date.now() tá aí pra isso 😄
Suggested change
| const today = new Date() | |
| const createdAt = new Date(body.created_at) | |
| const differenceDates = today.getTime() - createdAt.getTime() | |
| const differenceDates = Date.now() - new Date(body.created_at).getTime() |
| @@ -2,7 +2,8 @@ import { | |||
| i19buy, | |||
| i19connectionErrorProductMsg, | |||
| i19outOfStock, | |||
| i19unavailable | |||
| i19unavailable, | |||
| i19new | |||
There was a problem hiding this comment.
Quebrou a ordem alfabética aí 😬
| @@ -61,7 +62,11 @@ export default { | |||
| }, | |||
| isLoaded: Boolean, | |||
| installmentsOption: Object, | |||
| discountOption: Object | |||
| discountOption: Object, | |||
| timeToNew: { | |||
There was a problem hiding this comment.
É o número de dias né, pensando na API do componente não fica mais claro a prop como daysToBeNew ou algo do tipo?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.