Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Database configure not always properly applying immediately on current connection #7330

Open
msullivan opened this issue May 10, 2024 · 2 comments
Open

Database configure not always properly applying immediately on current connection #7330

msullivan opened this issue May 10, 2024 · 2 comments
Assignees
@fantix
Labels
server

Comments

@msullivan
Copy link
Member

test_server_proto_configure_error is flaking occasionally: https://github.com/edgedb/edgedb/actions/runs/9007197736/job/24746488573

I would think it could also be cache related, but I think I saw the reverse happen too: the error having not been cleared during teardown.

I'm probably going to put a flake workaround
msullivan added a commit that referenced this issue May 10, 2024
@msullivan
Work around the configure test flake
b5b1aba 
Put a retry loop around it; this will still properly test the main
functionality being tested by that part of the case.

I've filed #7330 to track the issue, which got exposed by some new
testing added in #7287.
@msullivan msullivan mentioned this issue May 10, 2024
Merged
@msullivan
Copy link
Member Author

Here's one where it isn't getting cleared right: https://github.com/edgedb/edgedb/actions/runs/9025625652/job/24801671577?pr=7327

@msullivan
Copy link
Member Author

I think it is a race with the scheduled reintrospection

msullivan added a commit that referenced this issue May 10, 2024
@msullivan
Work around the configure test flake (#7331)
8e4f34c 
Put a retry loop around it; this will still properly test the main
functionality being tested by that part of the case.

I've filed #7330 to track the issue, which got exposed by some new
testing added in #7287.
vpetrovykh pushed a commit that referenced this issue May 21, 2024
@msullivan @vpetrovykh
Work around the configure test flake (#7331)
caafe4f 
Put a retry loop around it; this will still properly test the main
functionality being tested by that part of the case.

I've filed #7330 to track the issue, which got exposed by some new
testing added in #7287.
vpetrovykh pushed a commit that referenced this issue May 22, 2024
@msullivan @vpetrovykh
Work around the configure test flake (#7331)
41e1fc5 
Put a retry loop around it; this will still properly test the main
functionality being tested by that part of the case.

I've filed #7330 to track the issue, which got exposed by some new
testing added in #7287.
vpetrovykh pushed a commit that referenced this issue May 22, 2024
@msullivan @vpetrovykh
Work around the configure test flake (#7331)
67bd03e 
Put a retry loop around it; this will still properly test the main
functionality being tested by that part of the case.

I've filed #7330 to track the issue, which got exposed by some new
testing added in #7287.
vpetrovykh pushed a commit that referenced this issue May 22, 2024
@msullivan @vpetrovykh
Work around the configure test flake (#7331)
48429f6 
Put a retry loop around it; this will still properly test the main
functionality being tested by that part of the case.

I've filed #7330 to track the issue, which got exposed by some new
testing added in #7287.
vpetrovykh pushed a commit that referenced this issue May 22, 2024
@msullivan @vpetrovykh
Work around the configure test flake (#7331)
26c00fd 
Put a retry loop around it; this will still properly test the main
functionality being tested by that part of the case.

I've filed #7330 to track the issue, which got exposed by some new
testing added in #7287.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fantix fantix

Labels
server
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@msullivan @fantix