Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array of targets is not typecheked in sample #957

Open
velialiev opened this issue Aug 2, 2023 · 1 comment
Open

Array of targets is not typecheked in sample #957

velialiev opened this issue Aug 2, 2023 · 1 comment
Labels
bug Something isn't working typings Typescript public type definitions issues

Comments

@velialiev
Copy link

What is the current behavior:

If you pass an array of targets to sample it won't typecheck them and will allow to pass inappropriate units there

Please provide the steps to reproduce and if possible a minimal demo of the problem via https://share.effector.dev, https://codesandbox.io or similar

https://stackblitz.com/edit/effector-vite-react-template-daaloz?file=src/model.ts

What is the expected behavior:

An array of targets must be typechecked in the same way as single unit

Which versions of effector packages, and which browser and OS are affected by this issue? Did this work in previous versions of effector?:

22.8.6

@velialiev velialiev added bug Something isn't working needs triage labels Aug 2, 2023
@stackblitz
Copy link

stackblitz bot commented Aug 2, 2023

@velialiev velialiev changed the title Array of targets is not typecheking in sample Array of targets is not typecheked in sample Aug 2, 2023
@zerobias zerobias added typings Typescript public type definitions issues and removed needs triage labels Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working typings Typescript public type definitions issues
Projects
None yet
Development

No branches or pull requests

2 participants