Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsibility for integration with framework should be part of "pluggins" #1034

Open
Legion112 opened this issue Jul 28, 2023 · 1 comment

Comments

@Legion112
Copy link

Is your feature request related to a problem? Please describe.
Integration with laravel should be part of the composer package but not this project
For example this commit: 32cf6e9#diff-b47c6775fb905ec115037a7131910fd0fa50c554269bcb6c418a6017fd7987f3
Invent knowledge of laravel artisan.

PROBLEM:
In order to contribute we need deep knowledge of this extension to be able to create integration with any third-party tools.
This project should be responsible only for offering a set of APIs which going to be used inside of the "integration" package.
This will reduce the responsibility to keep up with third-party tool releases and make this package "totally" independent.

For example, if LARAVEL decided to rename artisan to something else - we would need to update this repository but this particular change is only needed by people who use laravel not by others.

Describe the solution you'd like
Deprecate any integration with any framework and offer a separate package that is going to be responsible for integration with a framework for example naming laravel cli command or HTTP

The same goes for Symfony and any framework.

There are already packages which doing so like https://github.com/MySchoolManagement/elastic-apm-symfony-bundle

BENEFITS:
Maintainer of this repository can decrease load and do something that really useful for everyone.

Additional context

@Legion112 Legion112 added the enhancement New feature or request label Jul 28, 2023
@Legion112
Copy link
Author

Things like WordPress also at my opinion should be part of plugging but not this project
https://github.com/elastic/apm-agent-php/blob/main/agent/php/ElasticApm/Impl/AutoInstrument/WordPressAutoInstrumentation.php

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants