Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consider parsing Forwarded/X-Real-Ip/X-Forwarded-For headers to client.ip #53

Open
trentm opened this issue Feb 8, 2021 · 0 comments
Open

consider parsing Forwarded/X-Real-Ip/X-Forwarded-For headers to client.ip #53

trentm opened this issue Feb 8, 2021 · 0 comments
Labels
agent-nodejs Make available for APM Agents project planning.

Comments

@trentm
Copy link
Member

trentm commented Feb 8, 2021

Currently helpers.formatHttpRequest mainly uses req.socket.remoteAddress for the "client.ip" ECS field. It could consider using some of the HTTP request headers (esp. X-Forwarded-For) to set this. If using Express, then req.ip is used which sometimes will use X-Forwarded-For, depending on user configuration.
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Feb 8, 2021
@trentm trentm mentioned this issue Oct 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@trentm