[ES|QL] Convert string to datetime when the other size of an arithmetic operator is date_period or time_duration #108455
+44
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fang-xing-esql
added
>enhancement
:Analytics/ES|QL
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
Hi @fang-xing-esql, I've created a changelog YAML for you. |
alex-spies
reviewed
May 15, 2024
There was a problem hiding this comment.
Thanks @fang-xing-esql , looks good!
I'd increase test coverage a bit, though; maybe we could also add an analyzer/verifier test that confirms that arbitrary functions producing a (foldable) string can't be used, so that e.g. mv_concat("2024", "-04", "-01") + 1 day is invalid.
| @@ -0,0 +1,6 @@ | |||
| pr: 108455 | |||
| summary: "[ES|QL] Convert string to datetime when the other size of an arithmetic\ | |||
There was a problem hiding this comment.
Suggested change
| summary: "[ES|QL] Convert string to datetime when the other size of an arithmetic\ | |
| summary: "[ES|QL] Convert string to datetime when the other side of an arithmetic\ |
You'll probably need to update the typo in the PR title as well, otherwise the bot may not honor any changes to the changelog.
| implicitCastingArithmeticOperation | ||
| required_capability: string_literal_auto_casting_to_datetime_add_sub | ||
| from employees | ||
| | eval x = 1 day + "2024-01-01", y = 1 year + "2024-04-01" + 1 month, z = "2024-01-01" + 3600 seconds |
There was a problem hiding this comment.
- Maybe let's add a test for
to_datetime(null) + 1 day(and other durations/periods) as well. - This does not cover subtractions, let's add a test for those as well.
- Optionally, we could also add tests for expressions like
"2024-04-01" + (1 year + 1 day)and expressions where the literal datetime has a an hour/minute/second as well, although this is getting into paranoid territory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves : #108432
eval x = 1 day + "2024-01-01"this will work after this change. Users don't need to call to_dt explicitly like thiseval x = 1 day + to_dt("2024-01-01")