Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] IpFilterRemoteAddressFilterTests testThatFilteringWorksByIp failing #108441

Closed
gwbrown opened this issue May 8, 2024 · 4 comments
Closed

[CI] IpFilterRemoteAddressFilterTests testThatFilteringWorksByIp failing #108441

gwbrown opened this issue May 8, 2024 · 4 comments
Labels
:Distributed/Network Http and internode communication implementations low-risk An open issue or test failure that is a low risk to future releases Team:Distributed Meta label for distributed team >test-failure Triaged test failures from CI

Comments

@gwbrown
Copy link
Contributor

gwbrown commented May 8, 2024 •
edited

Reproduces on 7.17 for me, but not main.

Build scan:
https://gradle-enterprise.elastic.co/s/5re4kfzryrato/tests/:x-pack:plugin:security:test/org.elasticsearch.xpack.security.transport.netty4.IpFilterRemoteAddressFilterTests/testThatFilteringWorksByIp

Reproduction line:

./gradlew ':x-pack:plugin:security:test' --tests "org.elasticsearch.xpack.security.transport.netty4.IpFilterRemoteAddressFilterTests.testThatFilteringWorksByIp" -Dtests.seed=93C014DF2F03ECE3 -Dtests.locale=lv-LV -Dtests.timezone=Australia/Tasmania -Druntime.java=21

Applicable branches:
7.17

Reproduces locally?:
Yes

Failure history:
Failure dashboard for org.elasticsearch.xpack.security.transport.netty4.IpFilterRemoteAddressFilterTests#testThatFilteringWorksByIp

Failure excerpt:

java.lang.NullPointerException: Cannot invoke "org.elasticsearch.threadpool.ThreadPool.getThreadContext()" because "this.threadPool" is null

  at __randomizedtesting.SeedInfo.seed([93C014DF2F03ECE3:AF44F9C723B2787D]:0)
  at org.elasticsearch.xpack.security.transport.netty4.IpFilterRemoteAddressFilterTests.init(IpFilterRemoteAddressFilterTests.java:99)
  at jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
  at java.lang.reflect.Method.invoke(Method.java:580)
  at com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1758)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:980)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:996)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at org.junit.rules.RunRules.evaluate(RunRules.java:20)
  at org.apache.lucene.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:49)
  at org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:45)
  at org.apache.lucene.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:48)
  at org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:64)
  at org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:47)
  at org.junit.rules.RunRules.evaluate(RunRules.java:20)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:390)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:843)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:490)
  at com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:955)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:840)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:891)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:902)
  at org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:45)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at org.apache.lucene.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:41)
  at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
  at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at org.apache.lucene.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:53)
  at org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:47)
  at org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:64)
  at org.apache.lucene.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:54)
  at org.junit.rules.RunRules.evaluate(RunRules.java:20)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:390)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl.lambda$forkTimeoutingTask$0(ThreadLeakControl.java:850)
  at java.lang.Thread.run(Thread.java:1583)
@gwbrown gwbrown added :Distributed/Network Http and internode communication implementations >test-failure Triaged test failures from CI labels May 8, 2024
gwbrown added a commit that referenced this issue May 8, 2024
@gwbrown
AwaitsFix: #108441
8539583
@elasticsearchmachine elasticsearchmachine added Team:Distributed Meta label for distributed team needs:risk Requires assignment of a risk label (low, medium, blocker) labels May 8, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

mark-vieira added a commit that referenced this issue May 9, 2024
@mark-vieira
AwaitsFix #108441
572ce11
@mark-vieira
Copy link
Contributor

I've muted this since it's failed 81 times in the last two days.

@albertzaharovits I think this is related to #108408

@albertzaharovits
Copy link
Contributor

Thanks @mark-vieira . It is indeed a clumsily adjusted test during backporting. I'll fix it with: #108502

@idegtiarenko idegtiarenko mentioned this issue May 13, 2024
Merged
@idegtiarenko idegtiarenko added low-risk An open issue or test failure that is a low risk to future releases and removed needs:risk Requires assignment of a risk label (low, medium, blocker) labels May 13, 2024
elasticsearchmachine pushed a commit that referenced this issue May 13, 2024
@albertzaharovits
2 @before methods, not a good idea (#108502)
b6dad2b 
Fixes IpFilterRemoteAddressFilterTests testThatFilteringWorksByIp. There
were 2 "@ Before"-annotated methods that didn't play well together.

Fixes: #108441
@idegtiarenko
Copy link
Contributor

Should be fixed by #108502

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Distributed/Network Http and internode communication implementations low-risk An open issue or test failure that is a low risk to future releases Team:Distributed Meta label for distributed team >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@idegtiarenko @gwbrown @mark-vieira @albertzaharovits @elasticsearchmachine