Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace MockBlockFactory with LeakTracker #108475

Open
dnhatn opened this issue May 9, 2024 · 2 comments
Open

Replace MockBlockFactory with LeakTracker #108475

dnhatn opened this issue May 9, 2024 · 2 comments
Labels
:Analytics/ES|QL AKA ESQL Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)

Comments

@dnhatn
Copy link
Member

dnhatn commented May 9, 2024

MockBlockFactory is an excellent tool for tracking blocks/vectors. However, it's only available in the compute module, not in the ESQL module. Instead of making it available to the ESQL module, let's adjust the RefCounted of Vectors/Blocks and integrate with LeakTracker instead.
@dnhatn dnhatn added the :Analytics/ES|QL AKA ESQL label May 9, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label May 9, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@nik9000
Copy link
Member

nik9000 commented May 9, 2024

That'd be cool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Analytics/ES|QL AKA ESQL Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nik9000 @dnhatn @elasticsearchmachine