Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] DebMetadataTests test05CheckLintian failing #108514

Closed
mark-vieira opened this issue May 10, 2024 · 11 comments · Fixed by #108521
Closed

[CI] DebMetadataTests test05CheckLintian failing #108514

mark-vieira opened this issue May 10, 2024 · 11 comments · Fixed by #108521
Labels
needs:risk Requires assignment of a risk label (low, medium, blocker) :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team >test-failure Triaged test failures from CI

Comments

@mark-vieira
Copy link
Contributor

This looks to be fallout from #108088 due to the fact that we are not stripping debug symbols from these binaries.

Build scan:
https://gradle-enterprise.elastic.co/s/buie66rpbkbgs/tests/:qa:packaging:destructiveDistroTest.default-deb/org.elasticsearch.packaging.test.DebMetadataTests/test05CheckLintian

Reproduction line:

null

Applicable branches:
main

Reproduces locally?:
Didn't try

Failure history:
Failure dashboard for org.elasticsearch.packaging.test.DebMetadataTests#test05CheckLintian

Failure excerpt:

org.elasticsearch.packaging.util.Shell$ShellException: Command was not successful: [bash -c lintian --fail-on-warnings /opt/buildkite-agent/builds/bk-agent-prod-gcp-1715342669985179265/elastic/elasticsearch-periodic-packaging/distribution/packages/deb/build/distributions/elasticsearch-8.15.0-SNAPSHOT-amd64.deb]
   result: exitCode = [1] stdout = [W: elasticsearch: shared-lib-without-dependency-information usr/share/elasticsearch/lib/platform/linux-x64/libvec.so
N: 411 tags overridden (191 errors, 166 warnings, 54 info); 5 unused overrides] stderr = [warning: the authors of lintian do not recommend running it with root privileges!
warning: --fail-on-warnings is deprecated]

  at __randomizedtesting.SeedInfo.seed([504DF3A885E5975E:90B36F443F91F2E5]:0)
  at org.elasticsearch.packaging.util.Shell.runScript(Shell.java:143)
  at org.elasticsearch.packaging.util.Shell.run(Shell.java:73)
  at org.elasticsearch.packaging.test.DebMetadataTests.test05CheckLintian(DebMetadataTests.java:45)
  at jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
  at java.lang.reflect.Method.invoke(Method.java:580)
  at com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1758)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:946)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:982)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:996)
  at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:61)
  at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:61)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:390)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl.lambda$forkTimeoutingTask$0(ThreadLeakControl.java:850)
  at java.lang.Thread.run(Thread.java:1583)
@mark-vieira mark-vieira added :Search/Search Search-related issues that do not fall into other categories >test-failure Triaged test failures from CI labels May 10, 2024
@elasticsearchmachine elasticsearchmachine added Team:Search Meta label for search team needs:risk Requires assignment of a risk label (low, medium, blocker) labels May 10, 2024
@mark-vieira
Copy link
Contributor Author

@ldematte I know we discussed this. Just opening this issue so we don't lose track of this.

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@ldematte
Copy link
Contributor

Hey @mark-vieira , when this is happened? I thought I fixed this with 06baf86

@breskeby
Copy link
Contributor

@ldematte last listed failure in test triage is this one: https://gradle-enterprise.elastic.co/s/m5pzhu7btxmnm/tests/task/:qa:packaging:destructiveDistroTest.default-deb/details/org.elasticsearch.packaging.test.DebMetadataTests/test05CheckLintian?top-execution=1

@mark-vieira
Copy link
Contributor Author

The above linked failure include that commit so it doesn't look like it's been mitigated.

@mark-vieira
Copy link
Contributor Author

It looks like the warning is shared-lib-without-dependency-information which is a problem with dependencies not being provided when the binary is being linked. So this is different than the debug symbols issue addressed in 06baf86.

@ldematte
Copy link
Contributor

That might be different: shared-lib-without-dependency-information
I see it as a warning, but maybe you are treating warnings as errors?
We actually have no dependency (as seen with ldd), but we do not compile with --nostdclib, which might leave "something" that trips lintian.
Is there a way for me to check lintian quickly on my local machine?

@mark-vieira
Copy link
Contributor Author

I see it as a warning, but maybe you are treating warnings as errors?

Correct.

Is there a way for me to check lintian quickly on my local machine?

I'd just spin up any debian based linux distro in docker, mount the build deb file into it and run lintian --fail-on-warnings.

@mark-vieira
Copy link
Contributor Author

FYI, you can build the debian package by just running ./gradlew buildDeb.

@mark-vieira
Copy link
Contributor Author

On an Apple silicon machine you'll actually want to use ./gradlew buildAarch64Deb.

@ldematte
Copy link
Contributor

I'll need to use x64 lintian/libs.
The aarch64 lib has been in for a while, and has not being tripping lintian for some reason (maybe the x64 version is more strict/more complete)

@ldematte ldematte mentioned this issue May 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs:risk Requires assignment of a risk label (low, medium, blocker) :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding override for lintian false positive on libvec.so ldematte/elasticsearch
4 participants
@breskeby @ldematte @mark-vieira @elasticsearchmachine