Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiDataGrid] Sorting popover scrollbar CSS bug/workaround #7567

Closed
wants to merge 3 commits into from
Closed

[EuiDataGrid] Sorting popover scrollbar CSS bug/workaround #7567

wants to merge 3 commits into from

Conversation

cee-chen
Copy link
Member

@cee-chen cee-chen commented Mar 11, 2024 •
edited

Summary

closes #7551

With scrollbar:

Browser Before After
Firefox
Safari
Chrome

Without scrollbar:

Before After

QA

  • On your Mac, open your system settings and go to Appearance > Show Scrollbars
  • Check Always
  • In Safari: Go to https://eui.elastic.co/pr_7567/#/tabular-content/data-grid and click Sort fields in the toolbar and then click Pick fields to sort by
  • Confirm Long long long field name is 1 line and is not cut off
  • Confirm the above is also true for Firefox
  • Confirm the above is also true for Chrome
  • Regression testing:
  • Go to any other datagrid example with fewer fields/no scrollbar and confirm it still works

General checklist

  • Browser QA
    • Checked in Chrome, Safari, Edge, and Firefox
    • Checked in mobile
      - [ ] Checked in both light and dark modes
      - [ ] Checked for accessibility including keyboard-only and screenreader modes
  • Docs site QA - N/A
  • Code quality checklist - N/A, CSS-only change
  • Release checklist
    • A changelog entry exists and is marked appropriately.
      - [ ] If applicable, added the breaking change issue label (and filled out the breaking change checklist)
  • Designer checklist - N/A

@cee-chen cee-chen mentioned this pull request Mar 11, 2024
Open
@cee-chen
Copy link
Member Author

Closing as I'm not a fan of the visual tradeoff of this workaround for popovers without a scrollbar. IMO, resolving this by redesigning the popover entirely to Caroline's comment in #5894 (comment) is a better holistic approach.

@cee-chen cee-chen closed this Mar 11, 2024
@cee-chen cee-chen deleted the datagrid/popover-bug branch March 11, 2024 18:19
@kibanamachine
Copy link

Preview staging links for this PR:

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[EuiDataGrid] Sort fields panel shows long names centralised on Safari
3 participants
@cee-chen @kibanamachine @elasticmachine