Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Unskip Related Integrations and Required Fields Cypress tests broken by an update to EUI v94.3.0 #183485

Closed
Tracked by #176909
nikitaindik opened this issue May 15, 2024 · 3 comments · Fixed by #183912
Closed
Tracked by #176909

[Security Solution] Unskip Related Integrations and Required Fields Cypress tests broken by an update to EUI v94.3.0 #183485

nikitaindik opened this issue May 15, 2024 · 3 comments · Fixed by #183912
Assignees
@nikitaindik
Labels
8.15 candidate Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. test v8.15.0

Comments

@nikitaindik
Copy link
Contributor

nikitaindik commented May 15, 2024 •
edited

An upgrade to EUI v94.3.0 with changes to EuiComboBox caused a Cypress test at to become flaky.

Test file: x-pack/test/security_solution_cypress/cypress/e2e/detection_response/detection_engine/rule_creation/common_flows.cy.ts

We have commented out the offending parts:

// fillRequiredFields();
// fillRelatedIntegrations();

EUI team is aware of the issue and is working on the fix. We'll need to uncomment these lines once the patched EUI version makes it into Kibana.

EUI issue: elastic/eui#7761
@nikitaindik nikitaindik added test Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team 8.15 candidate v8.15.0 labels May 15, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

@nikitaindik nikitaindik mentioned this issue May 15, 2024
Merged
@nikitaindik nikitaindik self-assigned this May 15, 2024
@banderror banderror mentioned this issue May 15, 2024
Open
nikitaindik added a commit that referenced this issue May 15, 2024
@nikitaindik
[Security Solution] Update flaky Cypress test for Related Integration…
1482fec 
…s to skip only the flaky part (#183490)

Updates the flaky test to skip only the flaky part instead of the whole
test.

**Test fail issue: #183437
**Issue to unskip completely later:
#183485
@nikitaindik nikitaindik changed the title [Security Solution] Unskip Related Integrations and Required Fields Cypress tests broken by an update to EUI v93.4.0 [Security Solution] Unskip Related Integrations and Required Fields Cypress tests broken by an update to EUI v94.3.0 May 21, 2024
@nikitaindik nikitaindik mentioned this issue May 21, 2024
Merged
nikitaindik added a commit that referenced this issue May 22, 2024
@nikitaindik
[Security Solution] Unskip previously flaky Cypress tests that intera…
89c4159 
…ct with combobox (#183912)

**Resolves: #183485

Unskips Related Integrations and Required Fields Cypress tests that were
made flaky by an update to `EuiComboBox` in EUI `v94.3.0`. This issue
was later fixed in EUI `v94.5.0`, so we are unskipping the tests.

🟢 Flaky test runner: [100 runs for ESS, 100 runs for
Serverless](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6058)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikitaindik nikitaindik

Labels
8.15 candidate Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. test v8.15.0
Projects
None yet
Milestone
No milestone
2 participants
@elasticmachine @nikitaindik