Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metric threshold rule alert on no data appears unchecked in UI even if value is set to true #183921

Open
ymao1 opened this issue May 21, 2024 · 3 comments
Labels
bug Fixes for quality problems that affect the customer experience Team:obs-ux-management Observability Management User Experience Team

Comments

@ymao1
Copy link
Contributor

ymao1 commented May 21, 2024

For the metric threshold rule type, the option to "alert on no data" is disabled if no "group by" field is specified, but it defaults to true when the rule is created. This creates a confusing user experience because the field appears to be unchecked (false) even when the value is true so users would have to inspect the rule configuration to know what the actual configuration is

Disabled row in the UI where the option is unchecked. For this rule, the alertOnNoData rule param is true
Screenshot 2024-05-21 at 9 58 35 AM

@ymao1 ymao1 added the Team:obs-ux-management Observability Management User Experience Team label May 21, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@jasonrhodes jasonrhodes added the bug Fixes for quality problems that affect the customer experience label May 29, 2024
@jasonrhodes
Copy link
Member

Let's check to see if this mismatch appears with the other "alert if group disappears" value (this ticket references "alertOnNoData" which isn't tied to the "Alert me if a group stops reporting data" checkbox.

Bigger question is whether we should ever let this value be "true" if there are no groups. Having a disabled checkbox marked "true" when it has no effect on the rule is also somewhat confusing.

@jasonrhodes
Copy link
Member

During refinement conversation, our recommendation is:

  1. Move no data settings into a single "Advanced Settings" section
  2. Do not disable the alert me if a group disappears box
  3. Change default value of that field to "false" instead of "true"
  4. Mention that this value is only relevant if a group is selected
  5. Add a link to extensive advanced settings documentation page in the single advanced settings section, where we can explain these more thoroughly

@maciejforcone @vinaychandrasekhar would love your thoughts on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:obs-ux-management Observability Management User Experience Team
Projects
None yet
Development

No branches or pull requests

3 participants