docs: improve protocol.handle file examples #42111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsanders11
added
target/30-x-y
dsanders11
added
semver/patch
ckerr
approved these changes
May 10, 2024
VerteDinde
approved these changes
May 10, 2024
codebytere
approved these changes
May 10, 2024
|
No Release Notes |
This was referenced May 13, 2024
|
I have automatically backported this PR to "30-x-y", please check out #42141 |
trop
bot
added
in-flight/30-x-y
and removed
target/30-x-y
|
I have automatically backported this PR to "31-x-y", please check out #42142 |
trop
bot
added
in-flight/31-x-y
merged/31-x-y
trop
bot
added
merged/30-x-y
Mrnikifabio
pushed a commit
to Mrnikifabio/electron
that referenced
this pull request
May 14, 2024
* docs: improve protocol.handle file examples * chore: fix lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #42102.
The current example at the top of the file doesn't handle the edge case where a filename has a
#, update it to match the pattern used in later examples. The second modified example was usingpath.joinwhich wouldn't work well with absolute paths so update that as well.cc @electron/docs
Checklist
Release Notes
Notes: none