Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detection_period propery works wrong #711

Closed
dmitrii-khr opened this issue May 10, 2024 · 2 comments
Closed

detection_period propery works wrong #711

dmitrii-khr opened this issue May 10, 2024 · 2 comments

Comments

@dmitrii-khr
Copy link

I'd like to complain again about the detection_period configuration property.
The following setup


 detection_period:
                period: day
                count: 1

transforms to the following statement in the elementary query which decides whether alert or not alert:

bucket_end >= 
    dateadd(day, cast('-1' as integer), cast(max_bucket_end as timestamp))

The non-strict condition means that it will alert for 2 days. But it is expected that the alert will be only one 1 day.
Now it is not possible to configure a time series test, to alert it for the current day and not for issues that were yesterday. 0 value causes test failure.

To Reproduce
setup time-series test with bucket size 1 day and detection_period 1 day

Expected behavior
With detection period of 1 day, test will not fail if start date of failed time bucket is more than 24 hours ago.
Condition which detects if test should fail have to be strict:

bucket_end >
    dateadd(day, cast('-1' as integer), cast(max_bucket_end as timestamp))

Environment (please complete the following information):

dbt package Version: 0.15.1

@dmitrii-khr
Copy link
Author

I suggest use here
strict >
and bucket_end > {{ elementary.edr_timeadd('day', backfill_period, 'max_bucket_end') }}

@haritamar
Copy link
Collaborator

Closing to contain the discussion in the other issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants