Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to file logging #163

Open
Ziinc opened this issue Dec 22, 2020 · 1 comment
Open

Improvements to file logging #163

Ziinc opened this issue Dec 22, 2020 · 1 comment
Labels
good first issue Good for newcomers

Comments

@Ziinc
Copy link
Collaborator

Ziinc commented Dec 22, 2020

Currently, in master, the logs are stored in a non-optional manner.

I think a good improvement for this would be to make the file logging optional, as not everyone has log rotation configured or needs logging (especially ad-hoc users).

Mentioned first here: #155 (comment)

Some improvements i can think of is:

@Ziinc Ziinc added the good first issue Good for newcomers label Jan 23, 2021
@Ziinc
Copy link
Collaborator Author

Ziinc commented Feb 4, 2021

#170 fixes point 1 and 2. Only making of file logger backend an opt in dep remains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant