Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic Opensearch telemetry to Electron App #9730

Closed
AdRiley opened this issue Apr 17, 2024 · 4 comments · Fixed by #9951
Closed

Add basic Opensearch telemetry to Electron App #9730

AdRiley opened this issue Apr 17, 2024 · 4 comments · Fixed by #9951
Assignees
@Frizi
Labels
-gui x-new-feature Type: new feature request
Milestone
Beta Release

Comments

@AdRiley
Copy link
Member

AdRiley commented Apr 17, 2024 •
edited by farmaazon

Events to track: open/close product/project (4 in total)
@AdRiley AdRiley added x-new-feature Type: new feature request -gui labels Apr 17, 2024
@AdRiley AdRiley added this to the Beta Release milestone Apr 17, 2024
@AdRiley AdRiley added the s-info-needed Status: more information needed from submitter label Apr 17, 2024
@farmaazon
Copy link
Contributor

farmaazon commented Apr 18, 2024 •
edited

Refinement notes:

  • The timestamp, user ID and URL to cloud endpoint should be passed by dashboard to GUI
  • We should use Elasticsearch (implementation may be taken from old GUI)

@farmaazon farmaazon changed the title Add basic telemetry to Electron App Add basic Opensearch telemetry to Electron App Apr 30, 2024
@Frizi Frizi self-assigned this May 6, 2024
@enso-bot
Copy link

enso-bot bot commented May 9, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2024-05-06):

Progress: Early proof of concept implementation for sending events from GUI through Cloud API. It should be finished by 2024-05-13.

@enso-bot
Copy link

enso-bot bot commented May 9, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2024-05-07):

Progress: Fixed GUI double-initialization to be able to send project opening events correctly. Added event logger implementation to dashboard and used it to mirror GA app open/close events. It should be finished by 2024-05-13.

@enso-bot
Copy link

enso-bot bot commented May 10, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2024-05-08):

Progress: Refactored GUI side event logging to use dashboard backend implementation, noticed problems with access tokens not being refreshed. It should be finished by 2024-05-13.

@farmaazon farmaazon removed the s-info-needed Status: more information needed from submitter label May 14, 2024
@Frizi Frizi mentioned this issue May 15, 2024
Merged
4 tasks
@mergify mergify bot closed this as completed in #9951 May 27, 2024
mergify bot pushed a commit that referenced this issue May 27, 2024
@Frizi
Expose cloud event logging endpoint to GUI and render GUI editor as r…
8edf493 
…eact component. (#9951)

fixes #9730

Added a `logEvent` method to remote backend implementation in dashboard. Added an always-present remote backend instance that can be used for logging even when running a local project (intentional behavior).

# Important Notes
Because the backend implementation requires access to always fresh session token, the logger needs to be periodically updated on GUI side, so it can continue to function. To accomplish that, I simplified the app loading logic to treat GUI as an ordinary react component, so its props can be updated with normal react rendering flow. That refactor also removed the dynamic GUI asset loading code that was only needed for Rust GUI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Frizi Frizi

Labels
-gui x-new-feature Type: new feature request
Projects
Issues Board
Status: 🗄️ Archived
Milestone
Beta Release
Development

Successfully merging a pull request may close this issue.

Expose cloud event logging endpoint to GUI and render GUI editor as react component. enso-org/enso
3 participants
@Frizi @AdRiley @farmaazon