Return type is not checked if it contains an error context (!)

[radeusgd]

I just found out we forgot to handle ! in our type ascriptions. For arguments that wasn't really used (even if allowed), so it was OK, but once we started using the same logic in return type checks that started to cause problems - if you add ! to your return type ascription (which is a good practice from perspective of documentation), the type check gets disabled.

Repro:

from Standard.Base import all

type My_Error

f1 x -> Integer ! My_Error = x
f2 x -> Integer = x

main =
    IO.println (f1 42)
    IO.println (f2 42)
    IO.println (Panic.recover Any (f1 "txt"))
    IO.println (Panic.recover Any (f2 "txt"))

Actual behaviour

42
42
txt
(Error: Type error: expected the result of `f2` to be Integer, but got Text.)

Expected behaviour

42
42
(Error: Type error: expected the result of `f1` to be Integer, but got Text.)
(Error: Type error: expected the result of `f2` to be Integer, but got Text.)

[enso-bot]

Radosław Waśko reports a new STANDUP for yesterday (2024-06-10):

Progress: Merged 2 PRs, 1 more (Types PoC) to go. Implemented the fix for return type check with complex types and extended test suite to avoid any regressions there; created PR. It should be finished by 2024-06-11.

Next Day: Next day I will be working on the #9486 task. Again get the pending PRs forward. Start work on followup to Snowflake Dialect.